Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when processing files with CR/LF (Windows) line endings #33

Closed
Maarten88 opened this issue Mar 18, 2014 · 3 comments
Closed

Error when processing files with CR/LF (Windows) line endings #33

Maarten88 opened this issue Mar 18, 2014 · 3 comments

Comments

@Maarten88
Copy link

Using vash with Docpad, if I save a file with "normal" line endings in Visual Studio, vash will not process the template at all. It outputs the template unmodified.

@kirbysayshi
Copy link
Owner

Vash's lexer attempts to normalize the endings to \n (https://github.com/kirbysayshi/vash/blob/master/src/vlexer.js#L167).

Is there a place I can see this bug in action?

I can't reproduce it with current vash: http://requirebin.com/?gist=kirbysayshi/9622558.

I'm not too familiar with docpad. Do you know what version of Vash it's using?

@Maarten88
Copy link
Author

I tried to recreate the problem in a small project on another pc, but it works fine and I couldn't reproduce the error no matter what file encoding or line ending I selected. Maybe the other project was using an older version of vash, I'll check that tomorrow. If there ever was a problem, it's fixed now.

@kirbysayshi
Copy link
Owner

Definitely let me know if you do discover what the issue was. I recently
fixed Vash to strip the BOM from a file, perhaps that was causing issues.

Yip yip,
~ Drew*

On Wed, Mar 19, 2014 at 5:35 PM, Maarten88 notifications@github.com wrote:

Closed #33 #33.

Reply to this email directly or view it on GitHubhttps://github.com//issues/33
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants