chore: update prism-php/prism version constraint in composer.json #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the version constraint for prism-php/prism from ^0.56.0 to >=v0.56.0 < v1.0 to allow for more flexible dependency management while preventing upgrades to v1.0 and above.
|
We could also set the max to v0.79, with the current setup only v0.56 can be run by the user, which misses significant features (like the responses API for OAI) |
luisdalmolin
approved these changes
Jul 9, 2025
|
Hmmm... not sure if this broke something. Tests were fine for me on v0.79, didn't run phpstan, which might have been a bad decision. Locally serving tools via http works fine for me, not sure if the errors from the run on main are relevant? Let me know if you don't have the time to investigate, then I'll take it on in the coming days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the version constraint for prism-php/prism from ^0.56.0 to >=v0.56.0 < v1.0 to allow for more flexible dependency management while preventing upgrades to v1.0 and above.
Alternatively, the version constraint could be updated often, but given the many releases of prism (we're already at
v0.79) I think this is the easier way.