Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tsl mass import #5329

Merged
merged 3 commits into from
Sep 22, 2022
Merged

Tsl mass import #5329

merged 3 commits into from
Sep 22, 2022

Conversation

markusweigelt
Copy link
Collaborator

Fixes #5311

solth
solth requested changes Sep 20, 2022
View reviewed changes
Copy link
Member

@solth solth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes work and fix the linked bug. Code also looks correct. Only thing missing is a test. Could you provide one, please, because the code affected by these changes is quite complex?

@markusweigelt
Copy link
Collaborator Author

@solth accidentally changed the tests for the process helper with the PR #5337.

@solth
Copy link
Member

solth commented Sep 22, 2022

@solth accidentally changed the tests for the process helper with the PR #5337.

Ok, that works for me, too.

@solth solth merged commit 1416e94 into kitodo:master Sep 22, 2022
@solth solth mentioned this pull request Sep 22, 2022
Closed
@markusweigelt markusweigelt deleted the tsl-mass-import branch November 7, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solth solth solth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TSL generation still bugged for mass import
2 participants
@markusweigelt @solth