Show dialog as feedback when user saves current data editor settings #5571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solth
requested review from
oliver-stoehr and
BartChris
and removed request for
oliver-stoehr
BartChris
approved these changes
Mar 6, 2023
|
Works good for me! Icon is deactivated when editor is started without task context and activated when started from a task. Message is displayed in english and german and settings are applied correctly. Code looks good. |
solth
force-pushed
the
editor-settings-saving-feedback
branch
from
adfb96f
to
6dd6eef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5565
Fixes #5527