-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Cython 0.27 #5406
Fixes for Cython 0.27 #5406
Conversation
…uire it. This will become an error in Cython 0.27, as it would depend on the type that Cython thinks it is calling (base or subtype) whether exceptions will be handled by the caller or not.
Note how it says |
Note that in CPython 3.5 and later, Cython now follows PEP 489 to improve the behaviour of module code. It is now very similar to Python modules, which also impacts relative imports, for example. Might be related. |
FYI, 0.27.1 will disable PEP-489 support again. It has proven to cause too much instability on user side. |
@scoder thanks for notifying! However, I guess you'd like to get it going asap? If that's the case, it's quite an issue for us. :) |
I guess you mean that we'd re-enable PEP-489? At some point, sure, but probably as an opt-in, or at least with safer defaults. Module reloading, for example, might not be allowed without user interaction. You can try the latest Cython master branch, it's essentially 0.27.1 already. |
Note that I would still recommend using proper relative imports ( |
@scoder I agree we need to fix it, I was just confirming the tests pass again i.e. that it's the PEP489 we had an issue with (I somewhat doubt it). @matham I changed
although |
Anyone anything against? Tested with buildozer and seems to work fine. |
a9d0273
to
cd7e220
Compare
\o/ |
Based on #5390 and trying to fix remaining issues. While it seems to be ok on py2, py3 for whatever reason tries to say
kivy.graphics.instructions
isn't available (it is actually ô_ô). Perhaps the error means I'm not on the right track?