Merge some fixes into stable #6357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge yet. We need to include a fix for #6358. |
|
Also #6362. |
tito
reviewed
Jun 3, 2019
| @@ -5,7 +5,8 @@ | |||
|
|
|||
| os.environ['KIVY_DATA_DIR'] = os.path.join(root, 'data') | |||
| os.environ['KIVY_MODULES_DIR'] = os.path.join(root, 'modules') | |||
| os.environ['GST_PLUGIN_PATH'] = os.path.join(sys._MEIPASS, 'gst-plugins') | |||
| os.environ['GST_PLUGIN_PATH'] = '{}{}{}'.format( | |||
| sys._MEIPASS, os.pathsep, os.path.join(sys._MEIPASS, 'gst-plugins')) | |||
There was a problem hiding this comment.
Why X/(X/Y) ? (X=_MEIPASS, Y=gst-plugins) ?
There was a problem hiding this comment.
os.pathsep is not the directory join (/), this is X;X/Y. because both directories are on the path. On windows, the plugins are in the root.
There was a problem hiding this comment.
I.e. on windows the plugins are in the same directory as the main binaries. We don't separate them out. So pyinstaller puts all the deps binaries in X, so it should be in the plugin path.
(cherry picked from commit e45d6d8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also bumps stable to 1.11.0.post0 so we can upload the fixes to pypi.