Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text: Properly raise errors reading a font #6754

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Text: Properly raise errors reading a font #6754

merged 1 commit into from
Mar 12, 2020

Conversation

matham
Copy link
Member

@matham matham commented Mar 1, 2020

Fixes these issues with the current code:

  • Errors are suppressed.
  • We're encoding a object already in bytes to bytes, which fails (bytes doesn't have encode).
  • We use an assertion instead of raising an exception.

@matham matham merged commit 81eaa2e into master Mar 12, 2020
@matham matham deleted the matham-patch-1 branch March 12, 2020 21:22
@matham matham added this to the 2.0.0 milestone Oct 28, 2020
@matham matham changed the title Properly raise errors reading a font. Text: Properly raise errors reading a font. Dec 9, 2020
@matham matham changed the title Text: Properly raise errors reading a font. Text: Properly raise errors reading a font Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: core-providers kivy/core
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@matham