Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes libiconv & libzbar configure host #1993

Conversation

AndreMiras
Copy link
Member

Having --host=x86 was making the configure script fail at enabling
shared library build on x86. This was resulting in failing to copy
libiconv.so and libzbar.so on x86 arch.

@AndreMiras
Copy link
Member Author

AndreMiras commented Sep 29, 2019

Hi @jtc0de 👋
Any idea why the TestGetSystemPythonExecutable.test_virtualenv is failing? The error is ModuleNotFoundError: No module named \'pytoml\'
Edit: #1994

Having `--host=x86` was making the configure script fail at enabling
shared library build on `x86`. This was resulting in failing to copy
`libiconv.so` and `libzbar.so` on `x86` arch.
@AndreMiras AndreMiras force-pushed the feature/fixes_libiconv_libzbar_configure_host branch from e1c3b51 to a095a55 Compare September 29, 2019 14:23
@AndreMiras
Copy link
Member Author

I've just rebased on upstream/develop which fixes #1994

@AndreMiras AndreMiras closed this Oct 5, 2019
@AndreMiras AndreMiras deleted the feature/fixes_libiconv_libzbar_configure_host branch October 5, 2019 18:57
@AndreMiras AndreMiras restored the feature/fixes_libiconv_libzbar_configure_host branch October 5, 2019 19:01
@AndreMiras
Copy link
Member Author

I deleted the branch my mistake, but this PR is still valid, re-opening.
@inclement could you take a look, build was green but I guess I may have to trigger again now 😕

@AndreMiras AndreMiras reopened this Oct 5, 2019
Copy link
Member

@inclement inclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@AndreMiras AndreMiras merged commit ac99e29 into kivy:develop Oct 5, 2019
@AndreMiras AndreMiras deleted the feature/fixes_libiconv_libzbar_configure_host branch October 5, 2019 21:31
@opacam opacam mentioned this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants