More tests and better handling for strtobool conversion

kiwitcms · Sep 19, 2017 · c87edd5 · c87edd5
1 parent 64c9a37
commit c87edd5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/tcms/core/ajax.py b/tcms/core/ajax.py
@@ -77,9 +77,14 @@ def __init__(self, request, product_id=None):
         def builds(self):
             from tcms.management.models import TestBuild
 
+            try:
+                _is_active = bool(strtobool(self.request.GET.get('is_active', 'False')))
+            except (ValueError, TypeError):
+                _is_active = False
+
             query = {
                 'product_id': self.product_id,
-                'is_active': bool(strtobool(self.request.GET.get('is_active', 'False')))
+                'is_active': _is_active
             }
             return TestBuild.list(query)
 

diff --git a/tcms/core/tests/test_ajax.py b/tcms/core/tests/test_ajax.py
@@ -10,3 +10,8 @@ def test_lowercase_string_is_converted_to_bool(self):
         url = "%s?info_type=builds&product_id=1&is_active=true" % reverse('ajax-info')
         response = self.client.get(url)
         self.assertEqual(200, response.status_code)
+
+    def test_empty_string_is_converted_to_bool(self):
+        url = "%s?info_type=builds&product_id=1&is_active=" % reverse('ajax-info')
+        response = self.client.get(url)
+        self.assertEqual(200, response.status_code)