Add TestBugAdmin file

[z-zafirov]

Created test_admin file to test BugAdmin view => if on admin page a user can click and be redirected to the new-bug form

[coveralls]

Coverage increased (+0.06%) to 75.341% when pulling 9cea49d on z-zafirov:zdravko_wip into 81f7ace on kiwitcms:master.

[atodorov]

More changes needed:

1. squash both commits together
2. commit log message can be better - from the diff itself it is obvious that a new file is added and what it's name is, and the name is not TestBugAdmin. See this reference for how to write a good commit log: https://chris.beams.io/posts/git-commit/

[codecov]

Codecov Report

Merging #1446 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1446      +/-   ##
==========================================
+ Coverage   76.26%   76.28%   +0.02%     
==========================================
  Files         123      123              
  Lines        4580     4580              
  Branches      547      547              
==========================================
+ Hits         3493     3494       +1     
+ Misses        912      911       -1     
  Partials      175      175              

Impacted Files	Coverage Δ
tcms/bugs/admin.py	91.66% <0.00%> (+8.33%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c84bc09...db02429. Read the comment docs.

[atodorov]

Also ignored from previous review:

• squash all commits together
• commit log message can be better - from the diff itself it is obvious that a new file is added and what it's name is, and the name is not TestBugAdmin. See this reference for how to write a good commit log: https://chris.beams.io/posts/git-commit/

[zahari]

Yes that is easy too long :)

…

On Sun, Mar 29, 2020, 23:02 Alexander Todorov ***@***.***> wrote: ***@***.**** requested changes on this pull request. Also ignored from previous review: - squash all commits together - commit log message can be better - from the diff itself it is obvious that a new file is added and what it's name is, and the name is not TestBugAdmin. See this reference for how to write a good commit log: https://chris.beams.io/posts/git-commit/ ------------------------------ In tcms/bugs/tests/test_admin.py <#1446 (comment)>: > @@ -0,0 +1,20 @@ +# -*- coding: utf-8 -*- +# pylint: disable=invalid-name +from django.urls import reverse +from tcms.tests import LoggedInTestCase +from tcms.utils.permissions import initiate_user_with_default_setups + + +class TestBugAdmin(LoggedInTestCase): + ''' + Class to test Admin view bugs-related functionalities + ''' See pylint errors ------------------------------ In tcms/bugs/tests/test_admin.py <#1446 (comment)>: > +from django.urls import reverse +from tcms.tests import LoggedInTestCase +from tcms.utils.permissions import initiate_user_with_default_setups + + +class TestBugAdmin(LoggedInTestCase): + ''' + Class to test Admin view bugs-related functionalities + ''' + + @classmethod + def setUpTestData(cls): + super().setUpTestData() + initiate_user_with_default_setups(cls.tester) + + def test_user_being_redirected_to_add_bug_form(self): Naming ! test_add_view_redirects_to_new_bug_page — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1446 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAYGIK7JT6Y4ADHEMWXUYTRJ6SL3ANCNFSM4LPS5AHQ> .

[atodorov]

Make pylint happy & squash all commits into 1

[atodorov]

Make pylint happy

[atodorov]

Minor changes requested.

Squash commits together.

[atodorov]

Rebase & squash your commits. The PR contains unrelated changes which should not be the case.

[atodorov]

Drop the merge commit and the unrelated changes from the 1st commit.

[atodorov]

Closed in favor of #1642