Define TENANT_APPS b/c impossible to check for errors otherwise #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a setting which is relevant only for kiwitcms-tenants/django-tenants and for Kiwi TCMS represents a subset of all applications accessible to each tenant. These are the appilications which hold private data for that tenant. In the past we've had issues where adding a new app into INSTALLED_APPS (e.g. tcms.bugs) didn't make it into TENANT_APPS and resulted in all users being able to share bugs which we didn't want. Because TENANT_APPS is always a subset of INSTALLED_APPS it is not possible to check if we've added something to INSTALLED_APPS but forgot to add it into TENANT_APPS. That's why I'm moving this setting here and using it as a temporary variable to construct the full list of INSTALLED_APPS.
Codecov Report
@@ Coverage Diff @@
## master #1535 +/- ##
=======================================
Coverage 75.32% 75.33%
=======================================
Files 122 122
Lines 4637 4638 +1
Branches 569 569
=======================================
+ Hits 3493 3494 +1
Misses 946 946
Partials 198 198
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a setting which is relevant only for
kiwitcms-tenants/django-tenants and for Kiwi TCMS represents a
subset of all applications accessible to each tenant. These are
the appilications which hold private data for that tenant.
In the past we've had issues where adding a new app into
INSTALLED_APPS (e.g. tcms.bugs) didn't make it into TENANT_APPS
and resulted in all users being able to share bugs which we didn't
want.
Because TENANT_APPS is always a subset of INSTALLED_APPS it is not
possible to check if we've added something to INSTALLED_APPS but
forgot to add it into TENANT_APPS. That's why I'm moving this
setting here and using it as a temporary variable to construct the
full list of INSTALLED_APPS.