Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow username for default_tester/author/reviewer in rpc testcase.update #1548

Merged
merged 3 commits into from
Apr 20, 2020

Conversation

RMadjev
Copy link
Contributor

@RMadjev RMadjev commented Apr 15, 2020

No description provided.

@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #1548 into master will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
+ Coverage   76.06%   76.21%   +0.15%     
==========================================
  Files         123      123              
  Lines        4575     4579       +4     
  Branches      547      547              
==========================================
+ Hits         3480     3490      +10     
+ Misses        919      914       -5     
+ Partials      176      175       -1     
Impacted Files Coverage Δ
tcms/rpc/api/forms/testcase.py 100.00% <100.00%> (ø)
tcms/rpc/api/testcase.py 71.00% <0.00%> (+2.00%) ⬆️
tcms/core/forms/fields.py 77.41% <0.00%> (+12.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f664567...a3ad3cf. Read the comment docs.

Copy link
Member

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good but needs more tests and additional work for related fields.

tcms/rpc/api/forms/testcase.py Show resolved Hide resolved
tcms/rpc/tests/test_testcase.py Show resolved Hide resolved
tcms/rpc/tests/test_testcase.py Show resolved Hide resolved
@RMadjev RMadjev changed the title Allow username for default_tester in rpc testcase.update Allow username for default_tester/author/reviewer in rpc testcase.update Apr 18, 2020
Copy link
Member

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor changes requested around naming things and assertions.

tcms/rpc/tests/test_testcase.py Outdated Show resolved Hide resolved
tcms/rpc/tests/test_testcase.py Outdated Show resolved Hide resolved
tcms/rpc/tests/test_testcase.py Show resolved Hide resolved
tcms/rpc/tests/test_testcase.py Outdated Show resolved Hide resolved
@atodorov atodorov merged commit a92d13c into kiwitcms:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants