-
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow username for default_tester/author/reviewer in rpc testcase.update #1548
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1548 +/- ##
==========================================
+ Coverage 76.06% 76.21% +0.15%
==========================================
Files 123 123
Lines 4575 4579 +4
Branches 547 547
==========================================
+ Hits 3480 3490 +10
+ Misses 919 914 -5
+ Partials 176 175 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good but needs more tests and additional work for related fields.
c68b659
to
ce5d50d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor changes requested around naming things and assertions.
ce5d50d
to
a3ad3cf
Compare
No description provided.