Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testrun executions bulk actions skaffold #1559

Merged

Conversation

asankov
Copy link
Member

@asankov asankov commented Apr 18, 2020

contains the changes from #1546

just the HTML for the bulk action button.

the buttons look like this:
image

my idea is that whenever the user clicks them a modal would pop up, in which the user would provide the necessary input - https://www.patternfly.org/v3/pattern-library/widgets/#modal

@asankov asankov self-assigned this Apr 18, 2020
@codecov
Copy link

codecov bot commented Apr 18, 2020

Codecov Report

Merging #1559 into refactor_testrun_ui will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           refactor_testrun_ui    #1559   +/-   ##
====================================================
  Coverage                76.21%   76.21%           
====================================================
  Files                      122      122           
  Lines                     4398     4398           
  Branches                   510      510           
====================================================
  Hits                      3352     3352           
  Misses                     875      875           
  Partials                   171      171           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38c0d3d...c0e6b23. Read the comment docs.

@atodorov
Copy link
Member

Same comment as in #1546 (comment)

@asankov asankov force-pushed the testrun-executions-bulk-actions branch 2 times, most recently from 647cb27 to aa25a20 Compare April 28, 2020 22:33
@asankov
Copy link
Member Author

asankov commented Apr 29, 2020

@atodorov this is the state now:
Screen Shot 2020-04-29 at 19 18 05

IMO we need to keep the filter by fields, which make sense (like Name, Status, Priority, etc.)
Sort by - IDK, your call

  • kebap buttons next to the bulk actions buttons - I don't see how we can use it ATM. remove it?
  • the icons on the right about the different views should also go
  • the search icon - IDK, how is that different from filters, by you will you be searching?
  • result count - keep, I have updated it to be dynamic, not hard-coded
  • active filters - also keep. I am think that we can hide the Active filters: and Clear All filters text until a user adds a filter, only then should we should the text + the actual filter

@atodorov tell me what you think about these things and I will move forward with this

@atodorov
Copy link
Member

atodorov commented May 9, 2020

Blocked on #1549 + a rebase to pick up the remaining of the bulk-menu actions.

@atodorov atodorov force-pushed the refactor_testrun_ui branch 2 times, most recently from 7b79eea to 61ede13 Compare May 17, 2020 20:36
@asankov asankov force-pushed the testrun-executions-bulk-actions branch from c0e6b23 to 43c10c3 Compare May 30, 2020 00:11
@asankov asankov marked this pull request as ready for review May 30, 2020 10:42
@asankov asankov changed the title [WIP] Testrun executions bulk actions skaffold Testrun executions bulk actions skaffold May 30, 2020
@asankov
Copy link
Member Author

asankov commented May 30, 2020

missing a bulk selector, but that can be added later.

examples are missing from patternfly docs - patternfly/patternfly-3#1204

@atodorov
Copy link
Member

atodorov commented Jun 3, 2020

IMO we need to keep the filter by fields, which make sense (like Name, Status, Priority, etc.)

This PR is concerned only with the bulk-action buttons and making them work. Filters are out of context here and we'll discuss them later.

tcms/testruns/templates/testruns/get.html Outdated Show resolved Hide resolved
tcms/testruns/templates/testruns/get.html Outdated Show resolved Hide resolved
tcms/testruns/templates/testruns/get.html Outdated Show resolved Hide resolved
tcms/testruns/templates/testruns/get.html Outdated Show resolved Hide resolved
tcms/testruns/templates/testruns/get.html Outdated Show resolved Hide resolved
tcms/testruns/templates/testruns/get.html Show resolved Hide resolved
tcms/testruns/templates/testruns/get.html Show resolved Hide resolved
@asankov asankov force-pushed the testrun-executions-bulk-actions branch from e46293d to da326e9 Compare June 11, 2020 15:55
Copy link
Member

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several unresolved comments form the previous code review

@asankov
Copy link
Member Author

asankov commented Jun 20, 2020

There are several unresolved comments form the previous code review

The unresolved comments are around the functionality of the buttons. Let's merge the scaffold and I will work on the functionality next. Otherwise this PR will become really big

Copy link
Member

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status button should have drop-down items, see previous comment.

tcms/testruns/templates/testruns/get.html Outdated Show resolved Hide resolved
@atodorov
Copy link
Member

atodorov commented Aug 3, 2020

Similar issue with toolbar buttons alignment as in #1672 (review)

with translated version of filters that make sense - Name, Priority,
Category

Also, translate bulk-edit buttons
update it via JS

Remove hard-coded filters.
Put up some TODOs for later
to allign formatting of pasted code with file and project formatting
@asankov asankov force-pushed the testrun-executions-bulk-actions branch from 8f78901 to 11d0d65 Compare August 4, 2020 06:11
@atodorov atodorov merged commit 86c3605 into kiwitcms:refactor_testrun_ui Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants