-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testrun executions bulk actions skaffold #1559
Testrun executions bulk actions skaffold #1559
Conversation
Codecov Report
@@ Coverage Diff @@
## refactor_testrun_ui #1559 +/- ##
====================================================
Coverage 76.21% 76.21%
====================================================
Files 122 122
Lines 4398 4398
Branches 510 510
====================================================
Hits 3352 3352
Misses 875 875
Partials 171 171 Continue to review full report at Codecov.
|
cddca3d
to
b421260
Compare
Same comment as in #1546 (comment) |
647cb27
to
aa25a20
Compare
@atodorov this is the state now: IMO we need to keep the filter by fields, which make sense (like
@atodorov tell me what you think about these things and I will move forward with this |
Blocked on #1549 + a rebase to pick up the remaining of the bulk-menu actions. |
7b79eea
to
61ede13
Compare
c0e6b23
to
43c10c3
Compare
missing a bulk selector, but that can be added later. examples are missing from patternfly docs - patternfly/patternfly-3#1204 |
This PR is concerned only with the bulk-action buttons and making them work. Filters are out of context here and we'll discuss them later. |
e46293d
to
da326e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several unresolved comments form the previous code review
The unresolved comments are around the functionality of the buttons. Let's merge the scaffold and I will work on the functionality next. Otherwise this PR will become really big |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Status button should have drop-down items, see previous comment.
Similar issue with toolbar buttons alignment as in #1672 (review) |
in TestRun page
with translated version of filters that make sense - Name, Priority, Category Also, translate bulk-edit buttons
update it via JS Remove hard-coded filters. Put up some TODOs for later
to allign formatting of pasted code with file and project formatting
8f78901
to
11d0d65
Compare
contains the changes from #1546
just the HTML for the bulk action button.
the buttons look like this:
my idea is that whenever the user clicks them a modal would pop up, in which the user would provide the necessary input - https://www.patternfly.org/v3/pattern-library/widgets/#modal