Prompt.render refactoring and updates to docker-compose.yml #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For print and export there is a JavaScript function which alerts the user if no objects were selected. Inside get() the prompt was shown if the specified from_plan parameter didn't match an actual TestPlan. We default to setting the test plan to None as is the case when no test plan is specified.
This view function has never been used. It is not possible to delete TestPlans via the regular UI and we've disabled access to TestPlan admin in bf2b495. The only way to actually delete a TestPlan object is via the Django shell! If test plan is not to be used it should be disabled instead! With this view gone we also remove: - PLAN_DELELE_EMAIL_TEMPLATE setting - mail/delete_plan.txt template - handle_emails_pre_plan_delete signal handler - TestPlanEmailSettings.notify_on_plan_delete model field
The Export button inside TestPlan view does the same thing as the Case->Export sub-menu item in the Cases tab. I remove it becase the Case->Export sub-menu provides more flexibility (select what cases to export). Also remove the Export buttons from search and advanced search result templates. If you'd like to export the cases from a given plan you have to open it in a new browser window and use the menu - NO SHORTCUTS anymore!
The problem is that some older versions of docker do not allow
mounting of files between the host and the container, they only
allow mounting directories and volumes. The stock docker versions
on CentOS 7 and RHEL 7 do this. You may see a similar error:
ERROR: for kiwi_web Cannot start service web:
OCI runtime create failed: container_linux.go:348:
starting container process caused "process_linux.go:402:
container init caused "rootfs_linux.go:58: mounting
"/root/kiwi/contrib/ssl/kiwi-https.crt" to
rootfs "/var/lib/docker/overlay2 ....
To work around this problem I've moved the ssl certificates into
a common directory, mount that into the container and updated the
file paths where necessary.
WARNING: If you decide to override settings you will have to either
mount the settings file into the container or COPY that file and
rebuild the image!
this commit makes it easier to access the httpd logs, mostly useful in case of error, and adds a small section about troubleshooting in production. There could still be issues with SELinux and file ownership depending on how the host setup. The helper instroduced in this commit only gets applied if you use docker-compose to start Kiwi TCMS. If you don't logs will still be inside the container!
Pull Request Test Coverage Report for Build 685
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.