Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building against packaged libkainjow-mustache #359

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented May 21, 2020

The Debian/Ubuntu package for mustache.hpp installs it to
/usr/include/kainjow/mustache.hpp. Have meson look for it in that include
directory as well before erroring out.

Fixes #318.

@legoktm legoktm requested a review from mgautierfr May 21, 2020 01:27
@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #359 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   57.38%   57.38%           
=======================================
  Files          48       48           
  Lines        3614     3614           
  Branches     1815     1815           
=======================================
  Hits         2074     2074           
  Misses       1537     1537           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14af7b7...af9afab. Read the comment docs.

@stale
Copy link

stale bot commented Jun 1, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Jun 1, 2020
@legoktm legoktm force-pushed the packaged-mustache branch from 05530b9 to 75daae8 Compare June 12, 2020 01:26
@stale stale bot removed the stale label Jun 12, 2020
@legoktm legoktm requested a review from mgautierfr June 12, 2020 01:26
The Debian/Ubuntu package for mustache.hpp installs it to
/usr/include/kainjow/mustache.hpp. Have meson look for it in that include
directory as well before erroring out.

Fixes #318.
@mgautierfr mgautierfr merged commit c986290 into master Jun 12, 2020
@mgautierfr mgautierfr deleted the packaged-mustache branch June 12, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meson does not (always) check for mustache.hpp at the right place
3 participants