-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type stubs #94
Add type stubs #94
Conversation
@kjd You've approved the PR but not merged, is there something still left to do here? Also what are your thoughts on dropping Python 3.4? |
I didn't merge the commit before reconciling that very question, since the PR removes the 3.4 trove classifier. As to whether to drop 3.4, I'd like to do an inventory on the relying parties on this library to see where their Python support lies. I know |
Got it! I can gather a list of supported Python versions for dependent packages and report back. |
@kjd Here's direct dependency info I grabbed from my PyPI dependency dataset:
so the only dependencies that are effected would be ones that unpin idna 3.* and allow Python 3.4, those are:
|
Thanks for the quick and comprehensive answer. I guess I have no problem targeting 3.5+ moving forward. |
Saw that there were no type stubs for idna so went ahead and put them together. If you drop Python 3.4 (<1% of downloads) I can change them to be inline instead of
.pyi
files. Let me know what you think!