use Zend/zend_smart_string.h #88
Conversation
WalkthroughThe update modifies the inclusion of a header file in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
zstd.c (1)
33-37: Use angle-brackets for Zend header to avoid accidental local-file shadowingCore and bundled extensions consistently include Zend headers with the system-style form:
#include <Zend/zend_smart_string.h>Keeping the same style:
- Prevents the compiler from searching the current directory first (quotes form), which could accidentally resolve to an unrelated file if one appears in the build tree.
- Aligns with the immediately-following include
<zend_smart_str.h>.Diff:
-#include "Zend/zend_smart_string.h" +#include <Zend/zend_smart_string.h>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
zstd.c(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: thekid
PR: kjdev/php-ext-zstd#77
File: zstd.stub.php:13-22
Timestamp: 2025-04-20T19:39:56.258Z
Learning: The php-ext-zstd library aims to maintain compatibility with PHP 7, so PHP 8-specific syntax features like union types should be avoided in favor of PHPDoc annotations.
zstd.c (1)
Learnt from: thekid
PR: #77
File: zstd.stub.php:13-22
Timestamp: 2025-04-20T19:39:56.258Z
Learning: The php-ext-zstd library aims to maintain compatibility with PHP 7, so PHP 8-specific syntax features like union types should be avoided in favor of PHPDoc annotations.
🔇 Additional comments (1)
zstd.c (1)
33-37: Version guard is fine, but double-check your intent
php_smart_string.hdisappeared only in PHP 8.5, so both headers are available for PHP 7.2 – 8.4.
The current guard (< 70200) selects the new header for everything 7.2+. That’s perfectly safe, but if maximum flexibility is desired you could switch on header presence instead of the PHP version macro.Just confirm this matches the compatibility matrix you want to support.
|
Thanks |
Zend/zend_smart_string.hexists since 7.2ext/standard/php_smart_string.hremoved in 8.5.0alpha3Summary by CodeRabbit