Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add swift-format plugins #14

Merged
merged 3 commits into from
Nov 2, 2023
Merged

build: add swift-format plugins #14

merged 3 commits into from
Nov 2, 2023

Conversation

kkebo
Copy link
Owner

@kkebo kkebo commented Oct 3, 2023

No description provided.

@kkebo kkebo self-assigned this Oct 3, 2023
@kkebo
Copy link
Owner Author

kkebo commented Oct 3, 2023

This PR slows down the CI workflows because the package Benchmarks is built. So I don't merge it.

@kkebo kkebo closed this Oct 3, 2023
.github/workflows/swift.yml Outdated Show resolved Hide resolved
.swift-format Show resolved Hide resolved
@kkebo
Copy link
Owner Author

kkebo commented Oct 11, 2023

#19 may resolve #14 (comment).

@kkebo kkebo reopened this Oct 12, 2023
@kkebo kkebo force-pushed the swift-format-plugins branch 2 times, most recently from 5b3a34c to afc9936 Compare October 12, 2023 18:26
@kkebo
Copy link
Owner Author

kkebo commented Oct 12, 2023

  • before (without caches): 8m 59s
  • before (with caches): 2m 0s
  • after (without caches): 14m 37s
  • after (with caches): 2m 33s

@kkebo kkebo marked this pull request as ready for review November 2, 2023 18:16
@kkebo
Copy link
Owner Author

kkebo commented Nov 2, 2023

  • before (without caches): 8m 59s
  • before (with caches): 2m 0s
  • after (without caches): 14m 37s
  • after (with caches): 2m 33s

If swift package --package-path Benchmarks lint-source-code is removed, the time of "after" is as fast as the one of "before". Originally, the Benchmarks package was not built on GitHub Actions, so it's almost the same behavior if I remove that line.

@kkebo kkebo merged commit e5f1c2d into main Nov 2, 2023
1 check passed
@kkebo kkebo deleted the swift-format-plugins branch November 2, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants