Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R >=3.5 requirement #8

Closed
DavisVaughan opened this issue Oct 5, 2020 · 4 comments
Closed

R >=3.5 requirement #8

DavisVaughan opened this issue Oct 5, 2020 · 4 comments

Comments

@DavisVaughan
Copy link

Hi there! It looks like you recently made a release of lava that has a new R >= 3.5 requirement. According to this commit, it seems you want to enforce that readRDS() has support for the version 3 format that came with R 3.5. Is this required by your package? 28dd87b#diff-35ba4a2677442e210c23a00a5601aba3

In tidymodels, we implicitly rely on your package through recipes -> ipred -> prodlim -> lava. We try to maintain support for 5 versions of R where possible, which means that we support back through R 3.3 at the moment. Do you think it might be possible for lava to continue to support R versions back this far?

@klaus-holst
Copy link
Contributor

That's a fair point. This is fixed in 353465b.

@DavisVaughan
Copy link
Author

Thank you!

@kkholst
Copy link
Owner

kkholst commented Nov 5, 2020

Closing this as the new version 1.6.8.1, which now only depends on R>=3.0, has been published on CRAN.

@kkholst kkholst closed this as completed Nov 5, 2020
@DavisVaughan
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants