Introduce new event metrics and deprecate old ones - Backward compatible #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndurell
reviewed
Jan 11, 2024
ndurell
reviewed
Jan 11, 2024
ajaysubra
approved these changes
Jan 11, 2024
evan-masseau
commented
Jan 12, 2024
evan-masseau
force-pushed
the
event-name-fixes-non-breaking
branch
2 times, most recently
from
e6abc22
to
2d58548
Compare
Use new enums in tests, readme Make event name's string value extension public
evan-masseau
force-pushed
the
event-name-fixes-non-breaking
branch
from
2d58548
to
84ed142
Compare
evan-masseau
commented
Jan 12, 2024
| @@ -60,9 +60,9 @@ KlaviyoSDK().initialize(with: "YOUR_KLAVIYO_PUBLIC_API_KEY") | |||
| 3. Begin tracking events anywhere within your application by calling the `create(event:)` method in the relevant location. | |||
|
|
|||
| ```swift | |||
| let event = Event(name: .StartedCheckout, properties: [ | |||
| let event = Event(name: .AddedToCartMetric, properties: [ | |||
There was a problem hiding this comment.
@ndurell updated readme, thanks for the reminder
evan-masseau
commented
Jan 12, 2024
evan-masseau
changed the title
ndurell
approved these changes
Jan 12, 2024
This was referenced Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new cases for spelling corrections and add to cart.
Check List
Manual Test Plan
Supporting Materials
This is what a deprecation warning will look like
