Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Implement Bi-directional Communication #1652

Merged
merged 11 commits into from
Nov 10, 2022
Merged

Conversation

JayChoi1736
Copy link
Contributor

Proposed changes

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

networks/rpc/handler.go Show resolved Hide resolved
networks/rpc/http.go Outdated Show resolved Hide resolved
yoomee1313
yoomee1313 previously approved these changes Nov 4, 2022
@JayChoi1736
Copy link
Contributor Author

JayChoi1736 commented Nov 7, 2022

for reviewers:

  • the main difference between this PR and ethereum PRs( #18471, #19866 , #20289 ) is about metrics and limit.
    • metrics : rpcTotalRequestsCounter, rpcPendingRequestsCount, rpcSuccessResponsesCounter, rpcErrorResponsesCounter, rpcPendingRequestsCount, wsSubscriptionReqCounter, wsUnsubscriptionReqCounter, wsConnCounter
    • limit : MaxrequestContentLength, pendingRequestLimit, MaxSubscriptionPerWSConn, WebsocketReadDeadLine, WebsocketWriteDeadline, MaxWebsocketConnections, NonEthCompatible
    • handling logic of rpcPendingRequestCount and pendingRequestLimit is slicely changed. Formal logic counts pendingRequest only on multi-shot connections, but new logic will counts single-shot connections' requests as pendingRequest.
  • some rpc log msgs are added

networks/rpc/handler.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jiseongnoh jiseongnoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JayChoi1736 JayChoi1736 added this to the v1.10 (Kore) milestone Nov 8, 2022
@hyunsooda
Copy link
Contributor

Checked only the changes of SC package-related ones and confirmed no backward compatibility issue was discovered.
Cross-check please, @henry-will

Copy link
Contributor

@henry-will henry-will left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed about node/sc in this time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants