This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 187
Implement Bi-directional Communication #1652
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayChoi1736
requested review from
KimKyungup,
aidan-kwon,
ehnuje,
henry-will,
hyunsooda,
hqjang-pepper,
jiseongnoh,
mckim19,
kjhman21 and
jeongkyun-oh
as code owners
October 28, 2022 03:55
yoomee1313
reviewed
Nov 1, 2022
yoomee1313
previously approved these changes
Nov 4, 2022
for reviewers:
|
jiseongnoh
reviewed
Nov 7, 2022
jiseongnoh
reviewed
Nov 7, 2022
jiseongnoh
reviewed
Nov 7, 2022
jiseongnoh
reviewed
Nov 7, 2022
jiseongnoh
reviewed
Nov 7, 2022
jiseongnoh
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
yoomee1313
approved these changes
Nov 8, 2022
Checked only the changes of SC package-related ones and confirmed no backward compatibility issue was discovered. |
henry-will
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed about node/sc in this time.
aidan-kwon
reviewed
Nov 10, 2022
aidan-kwon
approved these changes
Nov 10, 2022
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR is derived from go-ethereum PRs
Fixed
Changed
Test
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...