Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent updates in ERC-1497 introduced new parameters to make dynamic scripts and evidence display interfaces less fragile, removing the need to hard-code JSON-RPC endpoints.
One particular edge case relates to cross-chain Meta Evidence, when the JSON file should contain a hard-coded
arbitrableChainID
to indicate which chain it belongs to. However this created a problem when callingArchon#arbitrable.getMetaEvidence()
because the caller cannot know the value ofarbitrableChainID
beforehand in order to be able to inject the properarbitrableJsonRpcUrl
into the dynamic script.To overcome that issue we are introducing a new option for
Archon#arbitrable.getMetaEvidence()
namedgetJsonRpcUrl
, which is a callback in the form:This new option will allow archon to obtain a JSON-RPC URL from
arbitrableChainID
after it downloads the original file so it can be injected intoscriptParameters
automatically.This change is supposed to be non-breaking and should not change the current behavior when
arbitrableChainID
is not defined.