Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order in DisputeRequest event #3

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Conversation

unknownunknown1
Copy link
Contributor

Changed order of the arguments and also reintroduced evidenceGroupID (renamed to localDisputeID) which was earlier removed from RequestSubmitted event

@unknownunknown1
Copy link
Contributor Author

Added a view contract. The main differences from the old one:

  • Removed any mention of appeals and rounds
  • Replaced metaevidenceId with dispute template
  • Some seemingly useless properties (e.g. currentRuling) removed.

Note that the old contract wasn't reviewed and apparently had some bugs. For instance, the way it fetches arbitration parameters would revert since arbitration and extraData should be fetched through an array where they're stored

@jaybuidl jaybuidl merged commit 2458ba0 into master Feb 5, 2024
@jaybuidl jaybuidl deleted the fix/curate-fixes branch February 5, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants