Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored cards #30

Merged
merged 16 commits into from
Sep 24, 2023
Merged

Refactored cards #30

merged 16 commits into from
Sep 24, 2023

Conversation

EmilyClare4
Copy link
Collaborator

  • 'Details' button now opens to the mushroom-detail page (which needs work)
  • 'Lookalikes' button currently opens a popup with placeholder words.
  • Changed button design

AdamN2424 and others added 16 commits September 22, 2023 13:43
@EmilyClare4 EmilyClare4 added the enhancement New feature or request label Sep 23, 2023
@EmilyClare4 EmilyClare4 self-assigned this Sep 23, 2023
AdamN2424
AdamN2424 approved these changes Sep 24, 2023
View reviewed changes
Copy link
Collaborator

@AdamN2424 AdamN2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result cards look great.
I think displaying the 'lookalike' description in the popup is fine for now since our data isn't fully prepared.
We can merge this to main, then add the other refactored filters.

joel-yap
joel-yap approved these changes Sep 24, 2023
View reviewed changes
Copy link
Collaborator

@joel-yap joel-yap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, the cards are ready to merge into master

@EmilyClare4 EmilyClare4 merged commit a23ff3e into master Sep 24, 2023
0 of 3 checks passed
@EmilyClare4 EmilyClare4 deleted the refactored-cards branch September 24, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamN2424 AdamN2424 AdamN2424 approved these changes

@joel-yap joel-yap joel-yap approved these changes

@RosieHall RosieHall Awaiting requested review from RosieHall

@kloudsoft91 kloudsoft91 Awaiting requested review from kloudsoft91

Assignees

@EmilyClare4 EmilyClare4

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmilyClare4 @joel-yap @AdamN2424