Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rather difficult to describe but kinda critical: Timing Problem #1345

Open
Lykdraft opened this issue Jun 9, 2021 · 9 comments
Open

Rather difficult to describe but kinda critical: Timing Problem #1345

Lykdraft opened this issue Jun 9, 2021 · 9 comments

Comments

@Lykdraft
Copy link

Lykdraft commented Jun 9, 2021

Try to recreate:
Add a delay (or any beat-synced effect) to a sound signal.
At the SeqBlock boundaries it will go completely offsync for half a second, then some
VSTs go into sync again, some don't (They go kinda back in sync, but with a beat-offset)

See picture to look at the spots where this is happening:

test

Then in the waveform Pic you can see what is happening:

testwawv

And in this mp3 you can hear what is happening.

testmp3.zip

In this case, it's just a delay but I think it showcases the problem quite well.
Every plugin that requires host-side tempo sync will more or less glitch out at the same spots...

This might be a difficult problem to solve or not, I am not sure.
But this is kinda critical. I find it odd though that this only happens on the boundaries of
the SeqBlock though. On the other hand, that might be clue?

I know that these kinds of glitches happen when looping in the editor,
but on song playback on the linear SeqTrack, I am not sure I've noticed this before...

Best,
tL.

@kmatheussen
Copy link
Owner

kmatheussen commented Jun 10, 2021 via email

@kmatheussen
Copy link
Owner

Can you try this song? I've tried to recreate the bug you described, using a saw 1/4 modulator on pitch, but can't hear anything wrong.
http://users.notam02.no/~kjetism/timingtest.rad

@kmatheussen
Copy link
Owner

My guess is that this is caused by rounding errors when calculating timing. I should change the calculation to use ratios instead of floating points. But sequencer timing gives a more stable BPM value, at least, than editor timing, so you might not see this then. If sequencer timing solves the problem at least I have a number to look at when trying to improve editor timing.

(When using editor timing, the BPM value switches frequently between 119.999 and 120.001, or something like that, but when using sequencer timing, the BPM value is constantly set at 120).

@Lykdraft
Copy link
Author

It was late, I deleted the post about the modulator. I guess something else was up there.
I try to setup a demo song later for you with an internal delay of something.
I hope this will show the error as well...

(IIRC I checked timing info on imperialDelay and it was also switching frequently between the two values, but on
on sequencer playback. I should add that I have a 60/40 swing going as well...(!) this might also play into this? )

@Lykdraft
Copy link
Author

Ok, the LADSPA Delay doesn't glitch. Happens only with VST/AU.

BUT you're right about switching to Sequencer Timing. That seems to solve this issue.
Cool. So this can be closed I think?

@Lykdraft
Copy link
Author

I'll take this as a yes... :)

@kmatheussen
Copy link
Owner

Sorry, I forgot this one. :-) Reopening as it is a real bug in editor timing. I guess it's just getting rid of the rounding errors in the timing calculations.

@kmatheussen kmatheussen reopened this Jun 11, 2021
@kmatheussen
Copy link
Owner

Also, could it be that you have enabled "Send swinging beats to plugins, modulators, metronomes, and jack transport" under File -> Song Properties? If so, maybe you don't see the bug if disabling this mode when using editor timing.

@Lykdraft
Copy link
Author

No, that's not enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants