Skip to content

Clarification Needed on Generated *-new.yaml Files #70

@Eeshu-Yadav

Description

@Eeshu-Yadav

Description

During development and testing, files with the pattern *-new.yaml are generated in orion-proxy/conf/. After investigation, these files are created by code in orion-configuration/src/config.rs, specifically in logic that serializes config files and writes the result as *-new.yaml for round-trip validation.

Relevant Code Location

let new_path = format!(
    "../orion-proxy/conf/{}-new.yaml",
    path.file_name()
        .unwrap()
        .to_str()
        .unwrap()
        .trim_end_matches(".yaml")
        .replace("envoy-", "orion-")
);
std::fs::write(new_path, serialized.as_bytes())?;

This code is found in orion-configuration/src/config.rs.

Current Behavior

  • When running tests or config validation, new YAML files (e.g., orion-runtime-new.yaml, orion-bootstrap-dyn-new.yaml, etc.) are generated in the orion-proxy/conf/ directory.
  • These files are not referenced by the main application or tests for runtime, and seem to be artifacts of config serialization checks.
  • Sometimes, these files are accidentally committed to the repository.

What I’ve Done

  • Added orion-proxy/conf/*-new.yaml to .gitignore to prevent accidental commits.
  • Clean them up locally after tests, but they still accumulate in the local filesystem.

Questions

  1. Are these *-new.yaml files required for any manual review, CI, or other workflow steps?
  2. Is it safe to ignore and clean them up after tests, or should the generation logic be changed (e.g., only generate on demand, or use in-memory checks)?
Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions