-
Notifications
You must be signed in to change notification settings - Fork 16
Closed
Description
Description
During development and testing, files with the pattern *-new.yaml
are generated in orion-proxy/conf/
. After investigation, these files are created by code in orion-configuration/src/config.rs
, specifically in logic that serializes config files and writes the result as *-new.yaml
for round-trip validation.
Relevant Code Location
let new_path = format!(
"../orion-proxy/conf/{}-new.yaml",
path.file_name()
.unwrap()
.to_str()
.unwrap()
.trim_end_matches(".yaml")
.replace("envoy-", "orion-")
);
std::fs::write(new_path, serialized.as_bytes())?;
This code is found in orion-configuration/src/config.rs
.
Current Behavior
- When running tests or config validation, new YAML files (e.g.,
orion-runtime-new.yaml
,orion-bootstrap-dyn-new.yaml
, etc.) are generated in theorion-proxy/conf/
directory. - These files are not referenced by the main application or tests for runtime, and seem to be artifacts of config serialization checks.
- Sometimes, these files are accidentally committed to the repository.
What I’ve Done
- Added
orion-proxy/conf/*-new.yaml
to.gitignore
to prevent accidental commits. - Clean them up locally after tests, but they still accumulate in the local filesystem.
Questions
- Are these
*-new.yaml
files required for any manual review, CI, or other workflow steps? - Is it safe to ignore and clean them up after tests, or should the generation logic be changed (e.g., only generate on demand, or use in-memory checks)?

Metadata
Metadata
Assignees
Labels
No labels