Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor Catalog #1372

Merged
merged 2 commits into from
Aug 20, 2019
Merged

refactor Catalog #1372

merged 2 commits into from
Aug 20, 2019

Conversation

takahashim
Copy link
Collaborator

  • Catalog#{chaps,parts,predef,postdef,appendix} should return Array, not String
  • fix read_*, remove cache @read_part

@kmuto
Copy link
Owner

kmuto commented Aug 19, 2019

これはそのまま取り込んでも副作用はなさそう?

@kmuto
Copy link
Owner

kmuto commented Aug 19, 2019

とりあえず部やCHAPS/PREDEF形式なども試してみましたが問題なさそうでした。

@takahashim
Copy link
Collaborator Author

APIとしてStringを返してたものがArrayを返すことになるので仕様変更ではあるのですが、Catalogオブジェクトを直接いじっているものでなければ問題ないかと思います。

@kmuto kmuto merged commit 37f81b3 into master Aug 20, 2019
@kmuto kmuto deleted the fix-catalog branch August 20, 2019 06:42
kmuto added a commit that referenced this pull request Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants