Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdfmakerでの実行コマンドをinfoレべルで表示する #968

Merged
merged 2 commits into from
Mar 7, 2018

Conversation

kmuto
Copy link
Owner

@kmuto kmuto commented Mar 1, 2018

#962 のシンプルな対応

ただ、copy_imagesで

          system('extractbb', '-B', @config['pdfmaker']['bbox'], *images)
          system_or_raise('ebb', '-B', @config['pdfmaker']['bbox'], *images) unless system('extractbb', '-B', @config['pdfmaker']['bbox'], '-m', *images)

とsystemを使ってるところがあって、そこはまだ入れていない。system_or_raiseと似た、raiseしないメソッドを作る必要がある?

@kmuto
Copy link
Owner Author

kmuto commented Mar 1, 2018

system_with_info()メソッドを作ったけど若干無駄がある気はする

@takahashim
Copy link
Collaborator

名前はちょっと変えるかもしれませんが、これはこれでまずマージしていいかと思いました

@kmuto
Copy link
Owner Author

kmuto commented Mar 7, 2018

Running ...とか入れたほうがいいのかなぁと思いつつ。とりあえずマージしておきます。

@kmuto kmuto merged commit f0ea945 into master Mar 7, 2018
@kmuto kmuto deleted the system_info branch March 7, 2018 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants