New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement reserved route. Fix cover image sizing. #18

Merged

onozasi merged 4 commits into knacksteem:master from ateufel:reserved

Aug 2, 2018

Contributor

ateufel commented Aug 1, 2018 •

edited

Loading

The Review component is used for reserved articles too, before it was just there for pending ones.
The cover image was not contained in the article list item, it is set to 100% width now - which means that it fits into the size of the parent container (280px).
The API backend URL was only working in production mode, this PR adds the localhost URL correctly so you can use the backend during development again.

ateufel added 4 commits

July 31, 2018 23:06


          rename review route to pending. add reserved route.

6b691f1


          refactor review routes to use only one react component.

b33dab0


          fix cover image sizing to fit into container.

281b6b2


          fix api backend url to work in development mode too.

528d877

onozasi merged commit 5765ab5 into knacksteem:master

ateufel deleted the reserved branch

August 3, 2018 13:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet