Implementation of User Profile Dashboard #39
Conversation
| @@ -0,0 +1,1028 @@ | |||
| { | |||
There was a problem hiding this comment.
How do I get rid of this?
| @@ -7,6 +7,7 @@ | |||
| "axios": "^0.18.0", | |||
| "express": "^4.16.3", | |||
| "express-http-to-https": "^1.1.4", | |||
| "fecha": "^2.3.3", | |||
There was a problem hiding this comment.
Where did you use this dependency
There was a problem hiding this comment.
Hi. I plan to use fecha to parse date on the Profile page. It's really lightweight and at 3kb gzipped it's a better alternative to Moment.js
There was a problem hiding this comment.
If you have a better/more efficient way of parsing dates, please let me know.
There was a problem hiding this comment.
Actually I saw this PR so i judged it that way it would be better if you introduced it just as you used it otherwise for this PR it looks like a unused dependency 🙂
You can keep it if you are going to use it
There was a problem hiding this comment.
I'm currently using it for the next pull.
| @@ -0,0 +1,3 @@ | |||
| import ProfileCategoriesBar from './ProfileCategoriesBar'; | |||
There was a problem hiding this comment.
This file just imports and exports another module we can simply import the module as it is just one module
There was a problem hiding this comment.
I use the Component Folder Pattern. It helps make code more searchable. However if the convention is against this, I will revert.
| @@ -0,0 +1,3 @@ | |||
| import ProfileHero from './ProfileHero'; | |||
| @@ -0,0 +1,3 @@ | |||
| import ProfileInfoBar from './ProfileInfoBar'; | |||
| @@ -0,0 +1,3 @@ | |||
| import ProfileMetaBar from './ProfileMetaBar'; | |||
| @@ -0,0 +1,3 @@ | |||
| import Profile from './Profile'; | |||
|
Okay I was performing the functional review Overall the UI looks good
These are not properly aligned If there is no name of the account the UI breaks see below Would be cool if the icon in the header after login leads to knacksteem profile instead of steemit profile. and the tabs Followers and Following is not working I suppose that is not done in the PR and would be done in another PR. Rest LGTM 👍 you can do the changes suggested above in the code and it is good to merge. |
This pull adds the user profile dashboard.
To have this feature fully implemented, moderation (make mod/remove mod) and account access (ban/unban) functionality must be integrated. This will be included in the next pull.
Also more comprehensive empty states should be added. Currently, only posts on the database are displayed. Maybe have them fetch from the blockchain perhaps?
References issue #35