Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Profile Dashboard Update: Contributions Lazy Loading on Demand. #47

Merged
merged 39 commits into from
Nov 25, 2018

Conversation

creatrixity
Copy link
Contributor

@creatrixity creatrixity commented Nov 22, 2018

contributions lazy loading

This pull updates the user profile dashboard.

On my previous pull, buttons for banning/unbanning users restricted by access levels and filtering articles according to their approval states were added..

Clicking the Load More button to load additional content has been added.

References issue #35

@ogbiyoyosky
Copy link
Contributor

ogbiyoyosky commented Nov 22, 2018

Nice Work @creatrixity. It seems there is a little bug on the filtering based on categories, please do check the filter mechanism other than everything looks good.
On the test, i can't seem to get the article with the category "art" which was posted.

@onozasi
Copy link
Contributor

onozasi commented Nov 23, 2018

Well done @creatrixity. I noticed that when I logged in with "knowledges" account, it is not assigned the "sup" role by default.

@onozasi
Copy link
Contributor

onozasi commented Nov 23, 2018

The following/follow tab should not redirect to steemit. Nothing should happen when these two tabs are clicked on, but they should perform the basic function of showing just the number of followed/followings.

@creatrixity
Copy link
Contributor Author

Fixed the master supervisor access and also fixed the bug described by @ogbiyoyosky

@onozasi
Copy link
Contributor

onozasi commented Nov 23, 2018

I am getting several errors each time I try going to kay's profile. I am not sure why this error pops up only on that user's profile. See gif below
http://localhost:3000/@kay

Also, the make sup, mod and ban function only appears on my profile. These functions should not appear on my profile page but on the profile page of others. See gif below.

The ban feature seems to work properly but its unclear to me why it's showing "ban kay" instead of the username of the user the "sup" wants to ban. E.g, I am currently on knowledges profile page, I expect to see "ban knowledges"

@creatrixity
Copy link
Contributor Author

@onozasi I've just pushed a fix of all these issues. The reason why accessing @kay gives an error is because @kay does not exist on the STEEM blockchain at all.

@onozasi
Copy link
Contributor

onozasi commented Nov 23, 2018

Alright. Another bug emerged. @kay is actually a valid Steem account. I am unable to describe the new bug but I've got a gif.

@creatrixity
Copy link
Contributor Author

@onozasi Fixed the bug that pops up whenever accessing non-knacksteem users or undocumented users such as our queer and mysterious Mr. @kay who seems to have a reputation of 0 with no steem power or vests of any sort (after some investigation)

@creatrixity
Copy link
Contributor Author

@onozasi Made a fix for that issue. Please check it out.

@onozasi
Copy link
Contributor

onozasi commented Nov 25, 2018

Bravo! Everything seems to work correctly now.

@onozasi onozasi merged commit 06abe2a into knacksteem:develop Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants