-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visibility test for Istio #74
Add visibility test for Istio #74
Conversation
@nak3: GitHub didn't allow me to request PR reviews from the following users: howardjohn. Note that only knative-sandbox members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
=====================================
Coverage 0.52% 0.52%
=====================================
Files 13 13
Lines 1713 1713
=====================================
Hits 9 9
Misses 1704 1704
Continue to review full report at Codecov.
|
Namespace: "knative-serving", | ||
Name: "test-gateway", | ||
}}, | ||
Allow: gatewayAllowTypePtr(gatewayv1alpha1.GatewayAllowAll), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come we aren't using GatewayAllowFromList anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Istio's Gateway needs to be deployed in istio-system
namespace, Contour also needs to use the Gateway in istio-system
namespace if we use GatewayAllowFromList
. (That's so strange.)
I will fix it by #75 in a separate PR.
@howardjohn: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
This patch adds visbility test for istio.
Also, it changes HTTPRoute's Gateway selector to
GatewayAllowAll
from
GatewayAllowFromList
. (So #47 is also covered eventually.)/cc @ZhiminXiang @markusthoemmes @howardjohn