Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visibility test for Istio #74

Merged
merged 5 commits into from
Jul 8, 2021
Merged

Add visibility test for Istio #74

merged 5 commits into from
Jul 8, 2021

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Jun 9, 2021

This patch adds visbility test for istio.

Also, it changes HTTPRoute's Gateway selector to GatewayAllowAll
from GatewayAllowFromList. (So #47 is also covered eventually.)

/cc @ZhiminXiang @markusthoemmes @howardjohn

@knative-prow-robot
Copy link
Contributor

@nak3: GitHub didn't allow me to request PR reviews from the following users: howardjohn.

Note that only knative-sandbox members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This patch adds visbility test for istio.

Also, it changes HTTPRoute's Gateway selector to GatewayAllowAll
from GatewayAllowFromList. (So #47 is also covered eventually.)

/cc @ZhiminXiang @markusthoemmes @howardjohn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 9, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 9, 2021
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #74 (c9e256c) into main (4ef7bba) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #74   +/-   ##
=====================================
  Coverage   0.52%   0.52%           
=====================================
  Files         13      13           
  Lines       1713    1713           
=====================================
  Hits           9       9           
  Misses      1704    1704           
Impacted Files Coverage Δ
test/conformance/ingressv2/run.go 0.00% <ø> (ø)
test/conformance/ingressv2/util.go 1.30% <0.00%> (ø)
test/conformance/ingressv2/visibility.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ef7bba...c9e256c. Read the comment docs.

Namespace: "knative-serving",
Name: "test-gateway",
}},
Allow: gatewayAllowTypePtr(gatewayv1alpha1.GatewayAllowAll),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come we aren't using GatewayAllowFromList anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Istio's Gateway needs to be deployed in istio-system namespace, Contour also needs to use the Gateway in istio-system namespace if we use GatewayAllowFromList. (That's so strange.)

I will fix it by #75 in a separate PR.

@knative-prow-robot
Copy link
Contributor

@howardjohn: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 8, 2021
@nak3 nak3 mentioned this pull request Jul 8, 2021
@ZhiminXiang
Copy link

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
@knative-prow-robot knative-prow-robot merged commit fed3431 into knative-extensions:main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants