-
Notifications
You must be signed in to change notification settings - Fork 67
Conversation
test/e2e-tests.sh
Outdated
|
||
subheader "Installing Knative Serving" | ||
kubectl apply -f ${SERVING_RELEASE} | ||
exit_if_test_failed "could not install Knative Serving" | ||
|
||
wait_until_pods_running build-system | ||
wait_until_pods_running knative-serving || exit_if_test_failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests shouldn't need serving components to be installed, can this be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last time I tried, tests failed when installing knative/build only. Maybe I missed something, I can try again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I must have done something wrong. It's working now, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, ImJasonH The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #29