Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github.com/mattn/go-localereader is reported in downstream projects by google/go-licenses tool #166

Closed
cardil opened this issue Mar 26, 2024 · 1 comment · Fixed by #167
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@cardil
Copy link
Contributor

cardil commented Mar 26, 2024

Bug description

Bubbletea is using the github.com/mattn/go-localereader as a dependency. It is used only for Windows, and maybe that's why it isn't reported here, by our go-licenses tooling. This lib is not very well maintained, as the only available version (v0.0.1), doesn't contain a license file. The license has been added to the main branch, however.

On downstream projects, it is reported by go-licenses as having missing license. Maybe this is because of it, being vendored here, IDK?

Unknown license type  found for library github.com/mattn/go-localereader

/kind bug

Steps to reproduce

  1. Checkout https://github.com/cardil/repro-kn-cli-bad-license
  2. Run test: go run github.com/google/go-licenses@latest check ./...
  3. You should license check failing, with error:
    Unknown license type  found for library github.com/mattn/go-localereader
    
@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 26, 2024
cardil added a commit to cardil/repro-kn-cli-bad-license that referenced this issue Mar 26, 2024
@cardil
Copy link
Contributor Author

cardil commented Mar 26, 2024

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant