Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Override localereader to use master branch version #167

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Mar 26, 2024

Changes

  • 🐛 Override localereader to use master branch version

/kind bug

Fixes #166

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 26, 2024
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.56%. Comparing base (cf1573f) to head (2741fa4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
- Coverage   57.56%   57.56%   -0.01%     
==========================================
  Files         112      113       +1     
  Lines        8387     8415      +28     
==========================================
+ Hits         4828     4844      +16     
- Misses       3298     3307       +9     
- Partials      261      264       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cardil
Copy link
Contributor Author

cardil commented Mar 26, 2024

@cardil
Copy link
Contributor Author

cardil commented Mar 26, 2024

/cc @rhuss
/cc @dsimansk

@knative-prow knative-prow bot requested review from dsimansk and rhuss March 26, 2024 19:46
@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
Copy link

knative-prow bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@knative-prow knative-prow bot merged commit ca2b56e into knative:main Mar 27, 2024
17 checks passed
@cardil cardil deleted the bugfix/localereader-license branch March 27, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github.com/mattn/go-localereader is reported in downstream projects by google/go-licenses tool
2 participants