Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests seem flaky #100

Closed
sixolet opened this issue May 9, 2019 · 4 comments
Closed

Integration tests seem flaky #100

sixolet opened this issue May 9, 2019 · 4 comments

Comments

@sixolet
Copy link
Contributor

sixolet commented May 9, 2019

In a way that doesn't seem to relate to any client code
@maximilien
Copy link
Contributor

Seems like there was an issue with getting Istio from servers. Seems fixed now.

@rhuss
Copy link
Contributor

rhuss commented Jun 27, 2019

We have now a new kind of Flake for the E2E when using the new go based workflow. Looks like a timing issue:

Failed to successfully execute 'kn service update hello --env TARGET=kn -n kne2etests': Execution error: stderr: 'Operation cannot be fulfilled on services.serving.knative.dev "hello": the object has been modified; please apply your changes to the latest version and try again
' error: 'exit status 1'FAIL	github.com/knative/client/test/e2e	1.792s

E.g. in #198

@rhuss rhuss mentioned this issue Jun 27, 2019
Merged
@rhuss
Copy link
Contributor

rhuss commented Jun 27, 2019

Sorry, overlooked #211 . Let's continue over there ....

@rhuss
Copy link
Contributor

rhuss commented Jun 28, 2019

I think it is fixed now. Let's close this issue and reopen or create a new one, if we see another flake.

@rhuss rhuss closed this as completed Jun 28, 2019
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@adrcunha @knative-prow-robot
Deal with error when checking for modified files (knative#100)
5cd512a 
If we can't get the list of modified files in a PR, assume tests need to be run. This will avoid leaving changed unguarded by tests.
dsimansk added a commit to dsimansk/client that referenced this issue Apr 27, 2023
@openshift-cherrypick-robot @dsimansk
Update version in spec file (knative#100)
73f0a0d 
Co-authored-by: David Simansky <dsimansk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maximilien @rhuss @sixolet