Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service replace #13

Closed
sixolet opened this issue Jan 29, 2019 · 6 comments · Fixed by #79
Closed

service replace #13

sixolet opened this issue Jan 29, 2019 · 6 comments · Fixed by #79
Milestone

Comments

@sixolet
Copy link
Contributor

sixolet commented Jan 29, 2019

Write the command to replace a service! It should take all new arguments just like create!

@csantanapr
Copy link
Member

/milestone v0.1.0

@knative-prow-robot
Copy link
Contributor

@csantanapr: You must be a member of the knative/knative-milestone-maintainers github team to set the milestone.

In response to this:

/milestone v0.1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csantanapr csantanapr added this to the v0.1.0 milestone Apr 5, 2019
@navidshaikh
Copy link
Collaborator

@sixolet : What would be the difference between service update and service replace ?

@sixolet
Copy link
Contributor Author

sixolet commented Apr 17, 2019 via email

@navidshaikh
Copy link
Collaborator

Alright.

so

kn service replace s1 --image registry.io/ns/image1:latest 

should replace an existing service s1 with specified params, and if s1 doesn't exist it should raise an error message.
Is this a sane behavior ?

@sixolet : are you planning to pick this one ? or I can take it.

@sixolet
Copy link
Contributor Author

sixolet commented Apr 18, 2019 via email

navidshaikh added a commit to navidshaikh/client that referenced this issue May 9, 2019
navidshaikh added a commit to navidshaikh/client that referenced this issue May 15, 2019
knative-prow-robot pushed a commit that referenced this issue May 15, 2019
* Adds --force flag to service create command / service replace

 Fixes #13

* Keeps the resourceVersion of service with --force flag

* Updates the tests

* Removes unnecessary comments
rhuss pushed a commit to rhuss/knative-client that referenced this issue May 27, 2019
…e#79)

* Adds --force flag to service create command / service replace

 Fixes knative#13

* Keeps the resourceVersion of service with --force flag

* Updates the tests

* Removes unnecessary comments
maximilien pushed a commit to maximilien/client that referenced this issue May 28, 2019
…e#79)

* Adds --force flag to service create command / service replace

 Fixes knative#13

* Keeps the resourceVersion of service with --force flag

* Updates the tests

* Removes unnecessary comments
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
Bonus: check credentials when uploading the config.
dsimansk pushed a commit to dsimansk/client that referenced this issue Dec 9, 2022
)

* Github action for multiarch test image builds

* Also remove redundant github actoins from upstream which we don't want
to run midstream.

* Change base image for ko buids to ubi-minimal

Same change as was done in Serving, Eventing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants