-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service replace #13
Comments
/milestone v0.1.0 |
@csantanapr: You must be a member of the knative/knative-milestone-maintainers github team to set the milestone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sixolet : What would be the difference between |
Update leaves any properties it doesn't change the same. Replace is like create: no properties will be on the service that you don't specify.
… On Apr 17, 2019, at 2:38 AM, Navid Shaikh ***@***.***> wrote:
@sixolet : What would be the difference between service update and service replace ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Alright. so
should replace an existing service @sixolet : are you planning to pick this one ? or I can take it. |
Go ahead.
… On Apr 18, 2019, at 12:57 AM, Navid Shaikh ***@***.***> wrote:
Alright.
so
kn service replace s1 --image registry.io/ns/image1:latest
should replace an existing service s1 with specified params, and if s1 doesn't exist it should raise an error message.
Is this a sane behavior ?
@sixolet : are you planning to pick this one ? or I can take it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
* Adds --force flag to service create command / service replace Fixes #13 * Keeps the resourceVersion of service with --force flag * Updates the tests * Removes unnecessary comments
…e#79) * Adds --force flag to service create command / service replace Fixes knative#13 * Keeps the resourceVersion of service with --force flag * Updates the tests * Removes unnecessary comments
…e#79) * Adds --force flag to service create command / service replace Fixes knative#13 * Keeps the resourceVersion of service with --force flag * Updates the tests * Removes unnecessary comments
Bonus: check credentials when uploading the config.
Write the command to replace a service! It should take all new arguments just like create!
The text was updated successfully, but these errors were encountered: