Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kn service get doesn't respect the current namespace #167

Closed
rhuss opened this issue Jun 6, 2019 · 1 comment
Closed

kn service get doesn't respect the current namespace #167

rhuss opened this issue Jun 6, 2019 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/duplicate This issue or pull request already exists

Comments

@rhuss
Copy link
Contributor

rhuss commented Jun 6, 2019 •
edited
Loading

Using kn service get just prints the Services from the "default" namespace, not only from the current one when no namespace is specified with --namespace.

Same is true for any other kn command. Indeed all command should pick up the current context from the configuation.
@rhuss rhuss added the kind/bug Categorizes issue or PR as related to a bug. label Jun 6, 2019
@rhuss rhuss mentioned this issue Jun 6, 2019
Closed
@rhuss
Copy link
Contributor Author

rhuss commented Jun 6, 2019

Well, I think it just creates in the "default" namespace in

client/pkg/kn/commands/namespaced.go

Lines 22 to 23 in ba59ad8

// TODO: default namespace should be same scope for the request
const defaultNamespace = "default"

@rhuss rhuss added the kind/duplicate This issue or pull request already exists label Jun 6, 2019
@rhuss rhuss closed this as completed Jun 6, 2019
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@bobcatfish @knative-prow-robot
Add trigger for integration tests (knative#167)
b29ff75 
The integration tests entrypoint in `presubmit-tests.sh`
(https://github.com/knative/build-pipeline/blob/master/test/presubmit-tests.sh#L46)
currently will just echo a `TODO` but I'd like to add this to Prow
before adding the logic to `presubmit-tests.sh` (especially b/c I don't
think I'll have permission to manually run these tests against the
boskos clusters in
https://github.com/knative/test-infra/blob/master/ci/prow/boskos/resources.yaml).

This is part of tektoncd/pipeline#16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhuss