Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command to install Knative #33

Closed
bbrowning opened this issue Mar 4, 2019 · 7 comments
Closed

Add a command to install Knative #33

bbrowning opened this issue Mar 4, 2019 · 7 comments

Comments

@bbrowning
Copy link
Contributor

It would be awesome if kn provided an easy way to install Knative. Even more awesome if it could work with a real Kubernetes cluster or let me choose to spin up Knative locally with minikube.

@cdrage
Copy link
Contributor

cdrage commented Mar 4, 2019

@bbrowning

knctl already has this and it work's well: https://github.com/cppforlife/knctl/blob/master/docs/basic-workflow.md

However.. wouldn't this be a difficult part of the knative client to maintain? Few points:

  • Every cluster is different, and even from experience I've had issues configuring Istio / Knative cloud vs bare metal
  • If we allow installation of knative is it implied that Istio is already installed? Or do we also install Istio?
  • Service accounts, each cluster has diffferent permissions / what they allow to be modified. Would we install RBAC permissions ourselves?

@kameshsampath
Copy link

@cdrage - can we not atleast do it for minikube ?

@bbrowning
Copy link
Contributor Author

I would agree that targeting only minikube initially would simplify a lot of the variables. We can setup a new minikube profile, start a fresh minikube VM, install Istio, install Knative, and do a bit of tuning out of the box to ensure things fit in a reasonably sized minikube instance.

@cdrage
Copy link
Contributor

cdrage commented Mar 4, 2019

@kameshsampath Istio is massive and requires A LOT of RAM to function. I've had to upgrade my homelab from 8GB to 32GB to even use it and when it does, it takes about 12GB.

Integrating it into Minikube / Minishift would be an option... but obviously we'll have to indicate to the user that you need a beefy machine to use it... enable it as an addon maybe?

@kameshsampath
Copy link

@cdrage if you install Istio from maistra then there are lot of components which our Knative OLM operators scales down after install. @bbrowning correct me if am wrong. I do my every day dev evangelism stuff with 8 GB minikubes.

@sixolet
Copy link
Contributor

sixolet commented Mar 4, 2019

Installing Knative is not part of the Knative API, and won't be. This is going to be an operator concern, not a developer concern. I'm closing this in the Client repo, we can make another similar bug in any operator repo as it develops.

@sixolet sixolet closed this as completed Mar 4, 2019
@bbrowning
Copy link
Contributor Author

@sixolet I understand your position. I created this issue based on feedback that there should be a very simple way to get Knative up and running on minikube, and minikube is not an operator in the same sense as cloud providers.

But, I'd concede that the most appropriate thing to do is to just simplify the kubectl-based install as much as possible for minikube.

coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants