Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want to see tags in 'kn route list' output #350

Closed
navidshaikh opened this issue Aug 8, 2019 · 8 comments
Closed

I want to see tags in 'kn route list' output #350

navidshaikh opened this issue Aug 8, 2019 · 8 comments
Labels
kind/feature New feature or request

Comments

@navidshaikh
Copy link
Collaborator

navidshaikh commented Aug 8, 2019

/kind feature
/kind proposal

Describe the feature:

Current kn route list output

./kn route list               
NAME   URL                                   AGE   CONDITIONS   TRAFFIC
svc    http://svc.default.apps-crc.testing   9h    3 OK / 3     0% -> svc-8cgjh, 50% -> svc-8cgjh, 50% -> svc-dw8kn

I want to know, what if my latest revision is receiving any traffic? OR which tag is receiving what portion of traffic?

If we could add tag along with revision name, like

./kn route list               
NAME   URL                                   AGE   CONDITIONS   TRAFFIC
svc    http://svc.default.apps-crc.testing   9h    3 OK / 3     0% -> svc-8cgjh (old), 50% -> svc-8cgjh (current), 50% -> svc-dw8kn (stable)

revision without tags will be printed without ().

@navidshaikh navidshaikh added the kind/feature New feature or request label Aug 8, 2019
@navidshaikh navidshaikh changed the title I want to see target tags in 'kn route list' output I want to see tags in 'kn route list' output Aug 8, 2019
@navidshaikh
Copy link
Collaborator Author

navidshaikh commented Aug 8, 2019

The traffic column is too long, we might want to consider

./kn route list               
NAME   URL                                   AGE   CONDITIONS   TRAFFIC
svc    http://svc.default.apps-crc.testing   9h    3 OK / 3     (old)svc-8cgjh=0, (current)svc-8cgjh=50, (stable)svc-dw8kn=50

replace -> with = and remove %

@zhanggbj
Copy link

@navidshaikh
Also feeling the traffic column is too long, and are you working on this? If not, I would like to take it.

@zhanggbj
Copy link

zhanggbj commented Aug 20, 2019

@navidshaikh
How about the output in this format revisionName(tag)=percent?

[zhanggong@192 client (refine_router_list ✗)]$ ./kn route list                                                                           
NAME            URL                                                   AGE     CONDITIONS   TRAFFIC
helloworld      http://helloworld.default.zhanggbj-knative.cloud      4m24s   3 OK / 3     helloworld-kp2pk=50%, helloworld-fw5zj=50%
helloworld-go   http://helloworld-go.default.zhanggbj-knative.cloud   35d     1 OK / 3     helloworld-go-6ttck(current)=100%

zhanggbj pushed a commit to zhanggbj/client that referenced this issue Aug 20, 2019
@toVersus
Copy link
Contributor

toVersus commented Aug 20, 2019

replace -> with = and remove %

I agree with Navid's idea to remove % from traffic percentage. @zhanggbj, WDYH?

@navidshaikh
Copy link
Collaborator Author

@zhanggbj :

How about the output in this format revisionName(tag)=percent?

I'd want to see the tag first (old)svc-8cgjh=0,, as if tag is present for a revision its preferred.

Also, lets put a hold on this, the AGE and CONDITIONS columns in resources listing seem not very useful. I'll put an issue for broader discussion about what do we present in listing vs describe.

@zhanggbj
Copy link

@toVersus @navidshaikh
Sure, we can follow format (old)svc-8cgjh=0.

@navidshaikh
could you please share the issue number you mentioned? Or I can continue with this issue here? Thanks!

zhanggbj pushed a commit to zhanggbj/client that referenced this issue Sep 12, 2019
- Show tag for revisionName if any
- Make the traffic colume shorter

[issue 350](knative#350)
zhanggbj pushed a commit to zhanggbj/client that referenced this issue Sep 16, 2019
- Show tag for revisionName if any
- Make the traffic colume shorter

[issue 350](knative#350)
zhanggbj pushed a commit to zhanggbj/client that referenced this issue Sep 16, 2019
- Show tag for revisionName if any
- Make the traffic colume shorter

[issue 350](knative#350)
zhanggbj pushed a commit to zhanggbj/client that referenced this issue Sep 16, 2019
- Show tag for revisionName if any
- Make the traffic colume shorter

[issue 350](knative#350)
zhanggbj pushed a commit to zhanggbj/client that referenced this issue Sep 17, 2019
- Show tag for revisionName if any
- Make the traffic colume shorter

[issue 350](knative#350)
zhanggbj pushed a commit to zhanggbj/client that referenced this issue Oct 22, 2019
- Only show NAME/URL/READY

[issue 350](knative#350)
zhanggbj pushed a commit to zhanggbj/client that referenced this issue Oct 22, 2019
- Only show NAME/URL/READY

[issue 350](knative#350)
zhanggbj pushed a commit to zhanggbj/client that referenced this issue Oct 23, 2019
- Only show NAME/URL/READY

[issue 350](knative#350)
knative-prow-robot pushed a commit that referenced this issue Oct 23, 2019
- Only show NAME/URL/READY

[issue 350](#350)
@navidshaikh
Copy link
Collaborator Author

The commands and their output have changed and we've better way to list the target tags. Closing.
/close

@knative-prow-robot
Copy link
Contributor

@navidshaikh: Closing this issue.

In response to this:

The commands and their output have changed and we've better way to list the target tags. Closing.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants