Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kn plugins #92

Closed
maximilien opened this issue May 3, 2019 · 7 comments · Fixed by #249
Closed

kn plugins #92

maximilien opened this issue May 3, 2019 · 7 comments · Fixed by #249
Assignees
Labels
kind/feature New feature or request

Comments

@maximilien
Copy link
Contributor

Add ability for the kn CLI to have plugins. This is particularly useful for three important scenarios:

  1. allows users of kn to extend it with functionality
  2. allows experimentation of commands that we don't want to include as a core command, e.g., $kn doctor
  3. allows those wanting to package kn with their own offering of Knative to extend kn with additional commands that either:
    a. is not yet included in the current release
    b. are experimental
    c. are specific to a cloud environment, e.g., IBM's Cloud or Google Cloud

There could be additional reasons to have plugins to kn so please add them here. Also if you are against such a feature, please comment your reasoning here too.

@maximilien
Copy link
Contributor Author

I will present and demo a proposal during Tuesday 04/06/2019's call.

@maximilien maximilien mentioned this issue May 3, 2019
@csantanapr
Copy link
Member

I think this is good idea to have, and if it can be done by importing a package from kubectl source code to replicate the plugin system that kubectl has.

I would avoid clone and own code from kubectl.

This allows also for design and prototype how new commands and the output would like like.

@maximilien
Copy link
Contributor Author

The following plugins WIP doc on my branch starts to motivate and give use cases to the proposed plugin that I will demo tomorrow.

@maximilien
Copy link
Contributor Author

@sixolet has created a kn plugin requirements doc which will be used to implement this feature.

Please consider joining the discussion. Once stable I will summarize the agreement here and hopefully we can start to implement that feature.

@maximilien
Copy link
Contributor Author

See PR #177 for first cut of plugins that match kubectl-style plugins.

@maximilien
Copy link
Contributor Author

/assign @maximilien

@csantanapr
Copy link
Member

This is great to see this feature landing
Thanks 💯 for the contribution @maximilien

dsimansk added a commit to dsimansk/client that referenced this issue Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
3 participants