Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revoke release leads permissions since 1.14 is out #1569

Merged
merged 2 commits into from
May 6, 2024
Merged

Revoke release leads permissions since 1.14 is out #1569

merged 2 commits into from
May 6, 2024

Conversation

izabelacg
Copy link
Member

Changes

  • Revoke release leads permissions since 1.14 is out

@knative-prow knative-prow bot requested review from krsna-m and psschwei May 6, 2024 18:01
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 6, 2024
@izabelacg izabelacg assigned izabelacg, dsimansk and Cali0707 and unassigned izabelacg May 6, 2024
Cali0707
Cali0707 reviewed May 6, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm from me
/cc @knative/technical-oversight-committee

@knative-prow knative-prow bot requested a review from a team May 6, 2024 18:07
@dsimansk
Copy link
Contributor

dsimansk commented May 6, 2024

I believe you need to run ./hack/update-codegen.sh to regen owners files based on peribolos config. Ci checks should catch it, let' see.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2024
psschwei
psschwei reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: izabelacg, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@knative-prow knative-prow bot merged commit b6eca60 into knative:main May 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei left review comments

@Cali0707 Cali0707 Cali0707 left review comments

@krsna-m krsna-m Awaiting requested review from krsna-m

Assignees

@dsimansk dsimansk

@psschwei psschwei

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@izabelacg @dsimansk @psschwei @Cali0707