Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Repo: adding educational-game repo to knative extensions #1599

Merged
merged 1 commit into from
Oct 10, 2024
Merged

New Repo: adding educational-game repo to knative extensions #1599

merged 1 commit into from
Oct 10, 2024

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Aug 1, 2024 •
edited
Loading

THE UX Working Group is developing an educational game to teach Knative concepts, starting with Eventing. We would like a new repo for this to live in, so that the main UX repo isn't filled with game artefacts and code

Changes

  • Add eventing-game repo to the repo list
  • Give Knative Admin admin permissions
  • Give UX Writers write permissions

@Cali0707
Copy link
Member Author

Cali0707 commented Aug 1, 2024

/cc @knative/technical-oversight-committee

@knative-prow knative-prow bot requested a review from a team August 1, 2024 13:27
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 1, 2024
@Cali0707
feat: add educational-game repo
fed0b14 
Signed-off-by: Calum Murray <cmurray@redhat.com>
@dsimansk
Copy link
Contributor

@Cali0707 are you still keen on getting the repo created?

@Cali0707
Copy link
Member Author

@dsimansk Yes, @zainabhusain227 and I have a presentation at KubeCon about this project. We've been using a repo under my personal GitHub for now, but it would be good to move back to a Knative repo

psschwei
psschwei reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part of #1598
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
@dsimansk
Copy link
Contributor

/lgtm

@dsimansk
Copy link
Contributor

IMO we got enough former TOC votes on the issue. Let's proceed!

@Cali0707 good luck on KubeCon!

@dsimansk
Copy link
Contributor

/unhold

@dsimansk
Copy link
Contributor

/approve

@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2024
@knative-prow knative-prow bot merged commit b3cd789 into knative:main Oct 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei left review comments

@dprotaso dprotaso Awaiting requested review from dprotaso

Assignees

@dsimansk dsimansk

@psschwei psschwei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cali0707 @dsimansk @psschwei