Skip to content

Conversation

grantr
Copy link
Contributor

@grantr grantr commented Jul 20, 2018

Previous links were broken.

Previous links were broken.
@google-prow-robot google-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 20, 2018
@grantr grantr requested a review from labadav July 20, 2018 21:21
Copy link
Contributor

@labadav labadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approval

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2018
@grantr
Copy link
Contributor Author

grantr commented Jul 20, 2018

@labadav the command is /approve

@labadav
Copy link
Contributor

labadav commented Jul 20, 2018

/approve

@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, labadav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot merged commit 4024489 into knative:master Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants