[multi-container]Add samples for multi container support #2732
Conversation
knative-prow-robot
added
the
size/L
savitaashture
force-pushed
the
samples-example
branch
from
26f9c1c to
76a8fe6
Compare
|
/test pull-knative-docs-markdown-link-check |
|
@abrennan89 are your comments addressed? |
|
Ack @dprotaso's comment. @savitaashture. Any news on finishing this PR? |
|
@savitaashture: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test all |
| ```go | ||
| package main | ||
| import ( | ||
| "fmt" | ||
| "io/ioutil" | ||
| "log" | ||
| "net/http" | ||
| ) | ||
| func handler(w http.ResponseWriter, r *http.Request) { | ||
| log.Println("serving container received a request.") | ||
| res, err := http.Get("http://127.0.0.1:8882") | ||
| if err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| resp, err := ioutil.ReadAll(res.Body) | ||
| if err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| fmt.Fprintln(w, string(resp)) | ||
| } | ||
| func main() { | ||
| log.Print("serving container started...") | ||
| http.HandleFunc("/", handler) | ||
| log.Fatal(http.ListenAndServe(":8881", nil)) | ||
| } |
There was a problem hiding this comment.
Is there a reason to duplicate the code & Dockerfiles in the README.md?
There was a problem hiding this comment.
I think it's fine if you don't and just leave the commands that explain how to build and run the multiple container knative service
There was a problem hiding this comment.
Just added to show it clearly for both serving and sidecar container
|
@savitaashture @dprotaso I don't think it matters about the tests that are failing since they're just the link checker and linter. |
|
@abrennan89 holding in case you have any last minute things /lgtm |
|
/hold |
knative-prow-robot
added
the
do-not-merge/hold
knative-prow-robot
added
lgtm
knative-prow-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrennan89, dprotaso, savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
woot 🎉 |
8 participants
Fixes knative/serving#8663
Proposed Changes
/cc @markusthoemmes @mattmoor @dprotaso