Clean up operator configmap docs #4618
Conversation
|
✔️ Deploy Preview for knative ready! 🔨 Explore the source changes: 59d6e5e 🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/61d726ba90a938000bf33b88 😎 Browse the preview: https://deploy-preview-4618--knative.netlify.app |
knative-prow-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrennan89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
/cherrypick release-1.0 |
|
@abrennan89: once the present PR merges, I will cherry-pick it on top of release-1.0 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-1.1 |
|
@abrennan89: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
|
||
| ## Examples | ||
|
|
||
| You can specify that the `KnativeServing` custom resource uses the `config-domain` ConfigMap as follows: |
There was a problem hiding this comment.
Might be overkill, so feel free to reject (LGTM otherwise)
| You can specify that the `KnativeServing` custom resource uses the `config-domain` ConfigMap as follows: | |
| You can specify that the `KnativeServing` custom resource uses the `config-domain` ConfigMap by setting `spec.config.domain` as follows: |
There was a problem hiding this comment.
I think it's OK without this but it's up to you :)
There was a problem hiding this comment.
I'm happy to defer :)
/lgtm
|
@abrennan89: new pull request created: #4619 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@abrennan89: new pull request created: #4620 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
Proposed Changes
Preview link: https://deploy-preview-4618--knative.netlify.app/development/install/operator/configuring-with-operator/