chore: fix docs page footer broken on mobile #6323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thisisobate <obasiuche62@gmail.com>
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
knative-prow
bot
added
the
size/M
|
/lgtm |
|
@dprotaso: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, thisisobate The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
@dprotaso: new pull request created: #6326 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
evankanderson
pushed a commit
to evankanderson/docs
that referenced
this pull request
Aug 13, 2025
Signed-off-by: thisisobate <obasiuche62@gmail.com>
knative-prow bot
pushed a commit
that referenced
this pull request
Aug 13, 2025
* Feat: New website (#6286) * chore: change theme font to satoshi font Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: create hero section Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: improve hero and need to know more sections Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: rename need to know more to what is knative Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: create why serverless section Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update feature icons and knative components sections Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update hero title headings Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update testimonial section Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update case studies items Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update why serverless feature cards with new content Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: tweak width of kelsey testimonial to align appropriately Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: tweak top nav layout Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update top nav links Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: change “readdocs” to “docs” Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: add spacing to the right of the nav menu Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix about link Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: remove home from sub nav Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: nit fix Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: nit fix Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: change cta button font color to white on hover Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix styling for testimonial section Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: make main headline font color to be black Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: rearrange nav items on the blog page Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: align serverless content block to center Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: reduce feature icons size on mobile screens Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: maintain consistent border radius size across cards Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: make knative components container span entire width on mobile Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix case studies section to be mobile responsive Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: make hero section mobile responsive Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: nit fix Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix section spacing in mobile Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: nit fix Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: reduce version warning title font size to be smaller Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: automatically hide duplicate menu items in sub nav using css Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: nit fix Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: conform text colors to match design Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: cleanup code Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: add the correct kelsey testimonial copy on homepage Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix some layout issues on mobile Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: Remove second paragraph from Kelsey testimonial on front page Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: Update Knative diagram image to the latest one with eventing icon as spiral Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: Update card background to match page background color Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: Put Kelsey testimonials in quote and make quote prominent Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: make kelsey testimonial card clickable Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update knative components overall design Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: make other card containers adopt new card design Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: change primary bg color to white Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix background bleed in kelsey testimonial image Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: text align feature contents to the left Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: make PNC card to be same size as others Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: reduce border width on hover to reduce flickering Signed-off-by: thisisobate <obasiuche62@gmail.com> --------- Signed-off-by: thisisobate <obasiuche62@gmail.com> * Fix casing of Knative (#6322) * chore: fix version picker overflowing into top nav (#6325) Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix docs page footer broken on mobile (#6323) Signed-off-by: thisisobate <obasiuche62@gmail.com> --------- Signed-off-by: thisisobate <obasiuche62@gmail.com> Co-authored-by: Uchechukwu Obasi <obasiuche62@gmail.com> Co-authored-by: Dave Protasowski <dprotaso@gmail.com>
evankanderson
pushed a commit
to evankanderson/docs
that referenced
this pull request
Aug 13, 2025
Signed-off-by: thisisobate <obasiuche62@gmail.com>
knative-prow bot
pushed a commit
that referenced
this pull request
Aug 13, 2025
* Feat: New website (#6286) * chore: change theme font to satoshi font Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: create hero section Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: improve hero and need to know more sections Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: rename need to know more to what is knative Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: create why serverless section Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update feature icons and knative components sections Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update hero title headings Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update testimonial section Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update case studies items Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update why serverless feature cards with new content Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: tweak width of kelsey testimonial to align appropriately Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: tweak top nav layout Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update top nav links Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: change “readdocs” to “docs” Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: add spacing to the right of the nav menu Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix about link Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: remove home from sub nav Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: nit fix Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: nit fix Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: change cta button font color to white on hover Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix styling for testimonial section Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: make main headline font color to be black Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: rearrange nav items on the blog page Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: align serverless content block to center Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: reduce feature icons size on mobile screens Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: maintain consistent border radius size across cards Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: make knative components container span entire width on mobile Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix case studies section to be mobile responsive Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: make hero section mobile responsive Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: nit fix Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix section spacing in mobile Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: nit fix Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: reduce version warning title font size to be smaller Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: automatically hide duplicate menu items in sub nav using css Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: nit fix Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: conform text colors to match design Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: cleanup code Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: add the correct kelsey testimonial copy on homepage Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix some layout issues on mobile Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: Remove second paragraph from Kelsey testimonial on front page Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: Update Knative diagram image to the latest one with eventing icon as spiral Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: Update card background to match page background color Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: Put Kelsey testimonials in quote and make quote prominent Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: make kelsey testimonial card clickable Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update knative components overall design Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: make other card containers adopt new card design Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: change primary bg color to white Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix background bleed in kelsey testimonial image Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: text align feature contents to the left Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: make PNC card to be same size as others Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: reduce border width on hover to reduce flickering Signed-off-by: thisisobate <obasiuche62@gmail.com> --------- Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix version picker overflowing into top nav (#6325) Signed-off-by: thisisobate <obasiuche62@gmail.com> * Fix casing of Knative (#6322) * chore: fix docs page footer broken on mobile (#6323) Signed-off-by: thisisobate <obasiuche62@gmail.com> --------- Signed-off-by: thisisobate <obasiuche62@gmail.com> Co-authored-by: Uchechukwu Obasi <obasiuche62@gmail.com> Co-authored-by: Dave Protasowski <dprotaso@gmail.com>
evankanderson
pushed a commit
to evankanderson/docs
that referenced
this pull request
Aug 13, 2025
Signed-off-by: thisisobate <obasiuche62@gmail.com>
knative-prow bot
pushed a commit
that referenced
this pull request
Aug 13, 2025
* Feat: New website (#6286) * chore: change theme font to satoshi font Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: create hero section Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: improve hero and need to know more sections Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: rename need to know more to what is knative Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: create why serverless section Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update feature icons and knative components sections Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update hero title headings Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update testimonial section Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update case studies items Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update why serverless feature cards with new content Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: tweak width of kelsey testimonial to align appropriately Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: tweak top nav layout Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update top nav links Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: change “readdocs” to “docs” Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: add spacing to the right of the nav menu Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix about link Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: remove home from sub nav Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: nit fix Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: nit fix Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: change cta button font color to white on hover Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix styling for testimonial section Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: make main headline font color to be black Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: rearrange nav items on the blog page Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: align serverless content block to center Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: reduce feature icons size on mobile screens Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: maintain consistent border radius size across cards Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: make knative components container span entire width on mobile Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix case studies section to be mobile responsive Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: make hero section mobile responsive Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: nit fix Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix section spacing in mobile Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: nit fix Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: reduce version warning title font size to be smaller Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: automatically hide duplicate menu items in sub nav using css Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: nit fix Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: conform text colors to match design Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: cleanup code Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: add the correct kelsey testimonial copy on homepage Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix some layout issues on mobile Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: Remove second paragraph from Kelsey testimonial on front page Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: Update Knative diagram image to the latest one with eventing icon as spiral Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: Update card background to match page background color Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: Put Kelsey testimonials in quote and make quote prominent Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: make kelsey testimonial card clickable Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: update knative components overall design Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: make other card containers adopt new card design Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: change primary bg color to white Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix background bleed in kelsey testimonial image Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: text align feature contents to the left Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: make PNC card to be same size as others Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: reduce border width on hover to reduce flickering Signed-off-by: thisisobate <obasiuche62@gmail.com> --------- Signed-off-by: thisisobate <obasiuche62@gmail.com> * Fix casing of Knative (#6322) * chore: fix version picker overflowing into top nav (#6325) Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix docs page footer broken on mobile (#6323) Signed-off-by: thisisobate <obasiuche62@gmail.com> --------- Signed-off-by: thisisobate <obasiuche62@gmail.com> Co-authored-by: Uchechukwu Obasi <obasiuche62@gmail.com> Co-authored-by: Dave Protasowski <dprotaso@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6295