Fix section "7-Connect Slack via Camel-K" in e2e tutorial. #6424
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
knative-prow
bot
added
the
size/L
twoGiants
changed the title
Overhauled the Camel K operator installation and configuration. Fixed issues with the overall setup, a few typos and wrong directory paths. The Pipe CR had a typo in the Broker name "bad-word-broker". Now it is correctly "badword-broker" Issue knative#6423. Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
twoGiants
force-pushed
the
issue-6423-fix-step-7-connect-slack
branch
from
971e0b6 to
af08818
Compare
| Here, we will be connecting `bookstore-broker` with a new Broker called `badword-broker`. And we will be creating a Trigger that helps us perform the filtering with the extension `badwordfilter: good`. | ||
|
|
||
| - 1: Append the following content to your `node-server/config/200-broker.yaml`: | ||
| - 1: Create a new file named `slack-sink/config/200-broker.yaml` and add the following content: |
There was a problem hiding this comment.
I am assuming the changes for the code files will be updated later right?
Same question for some of the few path changes in this PR as well.
There was a problem hiding this comment.
This one should be named 100-broker.yaml as in the solution! Missed that one.
I am assuming the changes for the code files will be updated later right?
Yeah, I opened the issue #6426 for the solution fixes. I am working on it today. Hope to open a PR for it today too.
Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
twoGiants
force-pushed
the
issue-6423-fix-step-7-connect-slack
branch
from
afc502c to
bf6b3f8
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, twoGiants The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/cherry-pick release-1.19 |
|
@dprotaso: new pull request created: #6434 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Overhauled the Camel K operator installation and configuration. Fixed issues with the overall setup, a few typos and wrong directory paths.
The Pipe CR had a typo in the Broker name "bad-word-broker". Now it is correctly "badword-broker". That was the reason for the "bad" comments not reaching the Slack sink.
Issue #6423.
/cherry-pick release-1.19
Proposed Changes
Update 7 - Connect Slack via Camel-K.
bookstore-brokername.kubectl patch ...command additionally tokubectl edit ....