Fix e2e tutorial solution files and documentation. #6429
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
knative-prow
bot
added
the
size/XXL
|
/cc @Leo6Leo |
Both function templates are updated to reflect the most recent version of the function cli. The code was also updated to build and execute. The `solution/setup.sh` was removed because it is empty. Mentioned Kind/Minikube with a link to the local registry setup docs in `solution/README.md`. This is needed for Camel K operator installation. Add corrected Camel K operator installation to `slack-sink/README.md` and to `solution.sh`. Also remove `kamel` cli installation check. Fixed typo and whitespace in the Javascript code of the node-server. Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
twoGiants
force-pushed
the
issue-6426-fix-e2e-tutorial-solution
branch
from
a6b9136 to
ec74b58
Compare
|
cc @matejvasek @lkingland for a pass over this /lgtm |
|
/cherry-pick release-1.19 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, twoGiants The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
@dprotaso: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dprotaso: new pull request created: #6433 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Overhauled the entire solution documentation and files adding corrected code and scripts. Mentioned that a Kind/Minikube cluster with a local registry is preferred to run the samples.
Fixes #6426.
Proposed Changes
solution/setup.shwas removed because it is empty.solution/README.md. This is needed for Camel K operator installation.slack-sink/README.mdand tosolution.sh. Also removekamelcli installation check.