rename webhook to be eventing-webhook to avoid potential clash #1269
Conversation
knative-prow-robot
added
the
size/M
|
@Harwayne @evankanderson any thoughts on this PR ? |
| name: config-logging | ||
|
|
||
| --- | ||
|
|
There was a problem hiding this comment.
Add a TODO to remove in 0.8.
There was a problem hiding this comment.
Will there be any conflicts between the two running simultaneously?
There was a problem hiding this comment.
The two won't run simultaneously (at least for more than a moment), because this YAML sets replicas=0 on the old Deployment, which will probably take effect around the same time as the new Deployment is started (probably faster, but not taking a bet).
If both end up running at once, they will both register their mutating webhook, but that should be fine -- whichever one is called earlier will do the defaulting, and the other will simply validate the same data which has been validated before.
| name: config-logging | ||
|
|
||
| --- | ||
|
|
There was a problem hiding this comment.
The two won't run simultaneously (at least for more than a moment), because this YAML sets replicas=0 on the old Deployment, which will probably take effect around the same time as the new Deployment is started (probably faster, but not taking a bet).
If both end up running at once, they will both register their mutating webhook, but that should be fine -- whichever one is called earlier will do the defaulting, and the other will simply validate the same data which has been validated before.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Fixes #1260
Proposed Changes
webhookto beeventing-webhookwebhookdeployment, but withreplicas: 0Release Note